Commit Graph

6 Commits

Author SHA1 Message Date
f9ae6fddfd Fix Blowfish and Blowfish2 correctness issues and improve initialization safety
In Blowfish
- Fix incorrect F-function byte extraction (critical bug).
- Correct key-schedule handling by using `uint8_t` key bytes.
- Initialize local variables in `initialize()` to prevent UB.
- Improve decrypt loop and XOR usage for clarity and correctness.

In Blowfish2
- Zero-initialize P-array and S-boxes to guarantee deterministic state.
- Fix incorrect key size comment (448 bits, not 4224 bits).
- Improve F-function byte extraction clarity.
- Normalize round loop logic and use XOR-assignment.

Others
- Replace macro `N` with `constexpr N`.
- Add `noexcept` to internal operations.
- Add `initialize(const uint8_t*, size_t)` overload for binary keys.
- Clean up readability and internal consistency across both ciphers.

Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
2025-12-04 21:11:16 +05:30
ee4bd0d21d fix: fix blowfish2 and add more tests
Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
2024-10-15 15:39:07 +05:30
960c48573e feat: add blowfish2 128 bit implementation
- regular blowfish only uses 64 bits
- blowfish2 uses 128 bits like AES

Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
2024-09-17 12:25:32 +05:30
avinal
279aaf34a4 source files updated with uint32_t 2021-03-07 23:46:04 +05:30
avinal
4394ff0b0d changed according to Google Guidelines 2021-03-06 23:13:10 +05:30
avinal
00fb066d2d blowfish source file added 2021-02-16 17:49:04 +05:30